From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Aug 2007 22:23:40 GMT
Subject: Re: [PATCH] git-filter-branch: document --original option
Message-ID: <7vodgo7jbn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <85d4x4d6oi.fsf@lola.goethe.zz>

David Kastrup <dak@gnu.org> writes:

> Junio C Hamano <gitster@pobox.com> writes:
> ...
>>  	--original)
>> +		case "$OPTARG" in */) ;; *) OPTARG="$OPTARG/" ;; esac
>>  		orig_namespace="$OPTARG"
>>  		;;
>>  	*)
>
> orig_namespace="${OPTARG%/}/"
>
> Sure, it does not win the "portable to Version 7" price, but our
> scripts don't do that, anyway.

I agree we do not give the "portable to version 7" prize
anymore.  But you made me realize another thing.

I think it should make sure orig_namespace has one and only one
trailing slash, because otherwise "--original refs/heads//"
would lead you to the same disaster.