From: Junio C Hamano Date: Thu, 08 Nov 2007 09:55:03 GMT Subject: Re: [PATCH] contrib/hooks/post-receive-email: add a From: line to the email header Message-ID: <7vode52hag.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071108094809.22151.qmail@97f06c2e73713e.315fe32.mid.smarden.org> Gerrit Pape writes: > $committer is already extracted from the latest existing rev, so add the > corresponding From: line to the email header. You may fight this out with Andy if you want to, but I think I'd side with the existing behaviour. commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b Author: Andy Parkins Date: Fri Sep 28 15:24:26 2007 +0100 post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used Using the name of the committer of the revision at the tip of the updated ref is not sensible. That information is available in the email itself should it be wanted, and by supplying a "From", we were effectively hiding the person who performed the push - which is useful information in itself. Signed-off-by: Andy Parkins Signed-off-by: Junio C Hamano diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 1f88099..cbbd02f 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -177,7 +177,6 @@ generate_email_header() # --- Email (all stdout will be the email) # Generate header cat <<-EOF - From: $committer To: $recipients Subject: ${EMAILPREFIX}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe X-Git-Refname: $refname