From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 23 Dec 2007 03:46:38 GMT
Subject: Re: [PATCH] Allow selection of different cleanup modes for commit messages
Message-ID: <7vodciul7l.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v1w9ew1vm.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> So I wonder if we should perhaps:
>>
>>  (a) Only add these messages at all when we do *not* do CLEANUP_ALL
>>
>> I personally would prefer (a) - since anybody who then explicitly uses
>> --cleanup={space|none} would presumably already know what he is doing.
>
> I thought about this a bit more, but then realized that people
> would still want to see the status output in their editors.
> This applies even to "verbatim" case.
>
> Which means that they need to remove the '#' lines when they do
> not use CLEANUP_ALL.
>
> So I am inclined to suggest we need to take (b).

... and I ended up doing the clean-up myself as I found a
handful buglets in the code before Alex's patch.

Will be posting them shortly.