From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Feb 2008 23:24:27 GMT
Subject: Re: [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time
Message-ID: <7vodahg5w4.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1203112418-25199-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> handle_filter() is only supposed to get one line at a time.
> handle_body() already ensures this after decoding BASE64 messages per
> this comment:
>
> /* this is a decoded line that may contain
>  * multiple new lines.  Pass only one chunk
>  * at a time to handle_filter()
>

Good eyes.  Although I do not think we need to quote in-code
comments here ;-)

> QP messages need to be similarly processed since decoding QP can also
> add newlines.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> I broke this change out into it's own patch since it's independent of
> the format=flowed additions.
>
>  builtin-mailinfo.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
> index 2600847..11f154b 100644
> --- a/builtin-mailinfo.c
> +++ b/builtin-mailinfo.c
> @@ -818,6 +818,7 @@ static void handle_body(void)
>  
>  		switch (transfer_encoding) {
>  		case TE_BASE64:
> +		case TE_QP:
>  		{
>  			char *op = line;
>  

And it appears to be an obvious fix that should even go to
'maint' where no new features will land.

Care to provide a test case for this one?