From: Junio C Hamano Date: Wed, 27 Feb 2008 19:18:16 GMT Subject: Re: [PATCH] Set proxy override with http_init() Message-ID: <7voda2us1z.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1204097780-29581-1-git-send-email-mh@glandium.org> Mike Hommey writes: > In transport.c, proxy setting (the one from the remote conf) was set through > curl_easy_setopt() call, while http.c already does the same with the > http.proxy setting. We now just use this infrastructure instead, and make > http_init() now take the proxy url as argument. > > At the same time, we make get_http_walker() take a proxy argument too, and > pass it to http_init(), which makes remote defined proxy be used for more > than get_refs_via_curl(). > > Signed-off-by: Mike Hommey > --- Thanks. I am kicking this to Daniel for a review ;-).