From: Junio C Hamano Date: Sun, 02 Mar 2008 17:00:26 GMT Subject: Re: [PATCH 2/3] specify explicit "--pretty=medium" with `git log/show/whatchanged` Message-ID: <7vod9xoyc5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1204448753-4471-2-git-send-email-crquan@gmail.com> Denis Cheng writes: > The following patch will introduce a new configuration variable, > "format.pretty", from then on the pretty format without specifying > "--pretty" might not be the default "--pretty=medium", it depends on > the user's config. So all kinds of Shell/Perl/Emacs scripts that needs > the default medium pretty format must specify it explicitly. > > Signed-off-by: Denis Cheng > --- > contrib/emacs/git.el | 2 +- > contrib/hooks/post-receive-email | 2 +- > git-cvsserver.perl | 2 +- > git-merge.sh | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) I think --pretty is enough and you do not have to say --pretty=medium, but as long as we are being explicit, we'd better be fully explicit to future proof them. The list of in-tree users and places match what I found with my quick review, which hopefully means both of us did our best effort to catch potential breakages. Thanks.