From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 07 Mar 2008 21:28:13 GMT
Subject: Re: [PATCH] unquote_c_style: fix off-by-one.
Message-ID: <7vod9q1axe.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080307092544.GA22069@chistera.yi.org>

Adeodato Simó <dato@net.com.org.es> writes:

> * Pierre Habouzit [Fri, 07 Mar 2008 01:44:01 +0100]:
>
>> On Thu, Mar 06, 2008 at 10:10:41PM +0000, Junio C Hamano wrote:
>> > Pierre Habouzit <madcoder@debian.org> writes:
>
>> > > Thanks to Adeodato Simò for having caught this.
>
>> > > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
>
>> > Thanks.  I would have appreciated a comment that said something about what
>> > external breakages this one caused, so that we can have an entry in "bugs
>> > fixed" list.
>
>> > A quick audit of the existing callers suggests that it is fast-import.
>
> Yes, it's fast-import. In particular, trying to rename a file whose name
> contains spaces:
>
>   R "file 1.txt" file 2.txt
>                 ^
>                 unquote_c_style() eats that space, thus fast-import
>                 fails with:
>
>                 fatal: Missing space after source: R "file 1.txt" file 2.txt
>

Thanks.