From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 May 2008 22:12:05 GMT
Subject: Re: [PATCH 1/3] diff options: Introduce --ignore-submodules
Message-ID: <7vod78k022.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0805142308400.30431@racer>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Wed, 14 May 2008, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > The point is: for the sake of a script (which wants to ignore 
>> > submodules) asking if there is a diff, I think it makes sense to not 
>> > ignore those changes.  IOW I think my patch is enough for the purpose 
>> > of getting stash/rebase to behave.
>> 
>> But the patch is not about stash/rebase but affects all diff users, 
>> doesn't it?
>
> Does it?  I thought I hid all that special handling behind the 
> --ignore-submodules options.

That's exactly the point.  The option reads "ignore submodules", not
"special option for use only by stash and rebase".