From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Jun 2008 19:12:28 GMT
Subject: Re: [PATCH 4/4] remote show: list tracked remote branches with -n
Message-ID: <7vod69cder.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1213109509-7013-1-git-send-email-dkr+ml.git@free.fr>

Olivier Marin <dkr+ml.git@free.fr> writes:

> From: Olivier Marin <dkr@freesurf.fr>
>
> Signed-off-by: Olivier Marin <dkr@freesurf.fr>
> ---
>  builtin-remote.c  |   25 +++++++++++++++++++++++--
>  t/t5505-remote.sh |    3 ++-
>  2 files changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/builtin-remote.c b/builtin-remote.c
> index 851bdde..de4a4f2 100644
> --- a/builtin-remote.c
> +++ b/builtin-remote.c
> @@ -444,6 +444,25 @@ static int get_remote_ref_states(const char *name,
>  	return 0;
>  }
>  
> +static int append_ref_to_tracked_list(const char *refname,
> +	const unsigned char *sha1, int flags, void *cb_data)
> +{
> +	struct ref_states *states = cb_data;
> +	struct strbuf buf;
> +
> +	strbuf_init(&buf, 0);
> +	strbuf_addf(&buf, "%s/", states->remote->name);
> +	if (strncmp(buf.buf, refname, buf.len)) {
> +		strbuf_release(&buf);
> +		return 0;
> +	}

Doesn't this have the same issue Shawn fixed in 7ad2458 (Make "git-remote
rm" delete refs acccording to fetch specs, 2008-06-01)?