From: Junio C Hamano Date: Wed, 27 Aug 2008 19:17:12 GMT Subject: Re: [PATCH 2/2] Improve portability: Avoid SS constant as it is already defined Message-ID: <7vod3ep8sn.fsf@gitster.siamese.dyndns.org> In-Reply-To: <7vwsi2p9qk.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > David Soria Parra writes: > >> From: David Soria Parra >> >> Constants that have the names of CPU registers are already defined >> in OpenSolaris's sys/regset.h. This causes a warning as we try to >> (re)define SS in ctype.c. So we just use another name. > > I do not mind this _particular_ workaround per-se, but I have to wonder > what happens the next time some random other platform has "SP" defined in > a random header file. If we are doing an workaround, how about doing it this way instead? ctype.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git i/ctype.c w/ctype.c index ee06eb7..d2bd38e 100644 --- i/ctype.c +++ w/ctype.c @@ -5,6 +5,11 @@ */ #include "cache.h" +/* Just so that no insane platform contaminates the namespace with these symbols */ +#undef SS +#undef AA +#undef DD + #define SS GIT_SPACE #define AA GIT_ALPHA #define DD GIT_DIGIT