From: Junio C Hamano Date: Wed, 03 Sep 2008 21:22:05 GMT Subject: Re: [PATCH 0/4] tests: use "git xyzzy" form Message-ID: <7vod359b7m.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080903210920.GA3199@coredump.intra.peff.net> Jeff King writes: > On Wed, Sep 03, 2008 at 04:59:45PM -0400, Jeff King wrote: > >> I just checked 1/4, which looks fine. Made much easier by the use of >> --color-words (even easier with -U0, but sometimes the context is >> helpful for seeing that it is correct). >> >> In 2/4, we change some instances of git-upload-pack, which you otherwise >> mentioned in your "should be left". It's in t5530 and t5602. Otherwise >> looks fine. > > And 3/4 and 4/4 look fine to me, too. Thanks, both. All four patches queued (with the tweak I mentioned to the test title of t5300 and t5305 in an earlier message).