From: Junio C Hamano Date: Wed, 19 Nov 2008 01:53:23 GMT Subject: Re: [PATCH 2/2] git-remote: add verbose mode to git remote update Message-ID: <7vod0ctrak.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1227006242-21290-1-git-send-email-crquan@gmail.com> crquan@gmail.com writes: > From: Cheng Renquan > > Pass the verbose mode parameter to the underlying fetch command. > > $ ./git remote -v update > Updating origin > From git://git.kernel.org/pub/scm/git/git > ... > Signed-off-by: Cheng Renquan > --- > So now the patch looks very simple. Indeed it does ;-), but there still is a minor nit. > + "git remote update [-v | --verbose] [group]", Notice the difference between the example in your commit log message and the help text? I think "git remote [options] [cmd] [more options]" which is the current option parser seems to try doing is very misguided, and a longer term fix-up might be to redo the cmd_remote() option parser, but in the short term, let's apply your patch with the following minor fixup: diff --git c/builtin-remote.c w/builtin-remote.c index 0af742b..abc8dd8 100644 --- c/builtin-remote.c +++ w/builtin-remote.c @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { "git remote rm ", "git remote show [-n] ", "git remote prune [-n | --dry-run] ", - "git remote update [-v | --verbose] [group]", + "git remote [-v | --verbose] update [group]", NULL };