From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 09 Apr 2009 00:29:31 GMT
Subject: Re: [PATCH] graph API: Added logic for colored edges
Message-ID: <7vocv6is9g.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090408214129.GA20764@linux.vnet>

Allan Caffee <allan.caffee@gmail.com> writes:

> The problem with making it an index into the column_colors array is that
> we don't have a convenient place to test whether the user actually wants
> color.  We can't do it in strbuf_write_column because AFAIK there's no
> way to get the rev-info to test the options.  I suppose we could define
> GIT_NOT_A_COLOR to -1 and just set the color to that when we don't
> intend to use color.  (Either way I should probably change that to an
> unsigned short.)  What do you think?

Sounds sensible.