From: Junio C Hamano Date: Mon, 16 Nov 2009 23:36:50 GMT Subject: Re: [PATCH] RFC Allow case insensitive search flag with git-grep for fixed-strings Message-ID: <7vocn2m48d.fsf@alter.siamese.dyndns.org> In-Reply-To: <20091116195050.6117@nanako3.lavabit.com> Nanako Shiraishi writes: > Quoting Brian Collins > >> You will have to excuse me, this is my first patch and I don't know if >> this is the right place to post this. Apologies in advance if I'm in >> the wrong place. >> >> git-grep currently throws an error when you combine the -F and -i >> flags. This isn't in line with how GNU grep handles it. This patch >> allows the simultaneous use of those flags. > > Junio, may I ask what happened to this patch? We got sidetracked into a larger picture issues of how to allow platform ports to selectively call out to external grep depending on the feature set supported by the external grep implementations. Later I looked at the original patch, the patch text looked fine (except that I would have called the field "ignorecase", not "caseless"), but it wasn't signed off and did not have usable log message. And then I forgot ;-) Thanks for a reminder, and thanks Jeff for a resend.