From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 09 Jan 2010 17:20:05 GMT
Subject: Re: [PATCH] daemon: consider only address in kill_some_child()
Message-ID: <7vocl3ry9m.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1263046408-2368-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@googlemail.com> writes:

> kill_some_child() compares the entire sockaddr_storage structure (with
> the pad-bits zeroed out) when trying to find out if connections
> originate from the same host.  However, sockaddr_storage contains the
> port-number for the connection (which varies between connections), so
> the comparison always fails.
>
> Change the code so we only consider the host-address, by introducing the
> addrcmp()-function that inspects the address family and compare as
> appropriate.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---

Makes sense.