From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Feb 2010 19:36:25 GMT
Subject: Re: [PATCHv4 1/6] environment: static list of repo-local env vars
Message-ID: <7vocjemnnq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cb7bb73a1002241120i4bbbce0bl50460c76db0c6529@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

> On Wed, Feb 24, 2010 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>>
>>> +/* Repository-local GIT_* environment variables */
>>> +const char *const local_repo_env[] = {
>>> +     ALTERNATE_DB_ENVIRONMENT,
>>> +     CONFIG_ENVIRONMENT,
>>> +     DB_ENVIRONMENT,
>>> +     GIT_DIR_ENVIRONMENT,
>>> +     GIT_WORK_TREE_ENVIRONMENT,
>>> +     GRAFT_ENVIRONMENT,
>>> +     INDEX_ENVIRONMENT,
>>> +     NO_REPLACE_OBJECTS_ENVIRONMENT,
>>> +     NULL
>>> +};
>>> +
>>> +const unsigned int local_repo_env_size = ARRAY_SIZE(local_repo_env);
>>
>> This does not look very useful for two reasons.

By the way, I said "frustrating" but didn't mean we should bend backwards.
The earlier one is more than Ok, and is certainly better than having
local_repo_env_size that is not very useful in practice.