From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Aug 2010 18:32:15 GMT
Subject: Re: [PATCH 5/7] t/t4016-diff-quote: change from skip_all=* to prereq skip
Message-ID: <7vocd9xaog.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1281469968-25670-6-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> diff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh
> index 34e5144..10e2db3 100755
> --- a/t/t4016-diff-quote.sh
> +++ b/t/t4016-diff-quote.sh
> @@ -11,14 +11,16 @@ test_description='Quoting paths in diff output.
>  P0='pathname'
>  P1='pathname	with HT'
>  P2='pathname with SP'
> +if P3='pathname
>  with LF'
> +: 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
> +then
> +	test_set_prereq TABS_IN_FILENAMES
> +else
> +	say 'Your filesystem does not allow tabs in filenames'
> +fi

Did you really mean to have that "if" before assignment to P3, and if so
why (as opposed to "after assignment to P3" or "before assignment to P0")?