From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Oct 2010 16:33:49 GMT
Subject: Re: [PATCH] repack: place temporary packs under .git/objects/pack/
Message-ID: <7vocaq16s2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cbdf4787ddaccd7105ab1661529a98257d61179b.1287481801.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> git-pack-objects is already careful to start out its temporary packs
> under .git/objects/pack/ (cf. 8b4eb6b, Do not perform cross-directory
> renames when creating packs, 2008-09-22), but git-repack did not
> respond in kind so the effort was lost when the filesystem boundary is
> exactly at that directory.
>
> Let git-repack pass a path under .git/objects/pack/ as the base for
> its temporary packs.
>
> This means we might need the $PACKDIR sooner (before the pack-objects
> invocation), so move the mkdir up just to be safe.
>
> Also note that the only use of *.pack is in the find invocation way
> before the pack-objects call, so the temporary packs will not suddenly
> show up in any wildcards because of the directory change.

Looks good; thanks.