From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Feb 2011 01:36:21 GMT
Subject: Re: [PATCH v5 2/4] merge: introduce setup_merge_commit helper function
Message-ID: <7voc6j1hey.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1297381964-7137-3-git-send-email-jaredhance@gmail.com>

Jared Hance <jaredhance@gmail.com> writes:

>  	for (i = 0; i < argc; i++) {
> -		struct object *o;
> ...
> -		strbuf_reset(&buf);
> +		setup_merge_commit(&buf, &remotes, argv[i]);
>  	}

Micronit; the body becomes a single statement and you should lose the {}.

Thanks.  No need to resend.