From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Sep 2011 22:18:01 GMT
Subject: Re: [PATCH 2/2] use new Git::config_path() for aliasesfile
Message-ID: <7voby1oesm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201110010000.13328.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> On Fri, 30 Sep 2011, Junio C Hamano wrote:
>
>> I think the addition of "config --path" support is a good idea, but the
>> resulting code suffers from too many cut&paste cruft across the config*
>> family of methods.
>> 
>> How about doing a bit of refactoring, perhaps something like this, on top
>> as a separate patch?
>
> This is a good idea, in my opinion.

Thanks.

>> I tried to be careful to still forcing the "one value only" for config_bool
>> and config_int, but extra sets of eyeballs would be needed.
>
> We do have tests for that, have we?

Perhaps, but I consider Perl "other peoples' problem" ;-) so...

> BTW. why do you use hashref?  Do you plan for the future to pass more
> options that 'kind'?

I don't, but other people might, and I didn't want to place undue burden
on them.