From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 Feb 2012 23:19:54 GMT
Subject: Re: [PATCH v4 11/13] status: add --column
Message-ID: <7vobtfld2d.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1328276078-27955-12-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> @@ -1251,7 +1260,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
>  	case STATUS_FORMAT_LONG:
>  		s.verbose = verbose;
>  		s.ignore_submodule_arg = ignore_submodule_arg;
> -		wt_status_print(&s);
> +		wt_status_print(&s, colopts);
>  		break;
>  	}

Do you really need to pass colopts around as a separate parameter all the
way through the callchain?

Why isn't it a new member of wt_status that sits next to existing
use_color, verbose, etc. that define _how_ the status is shown?