From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Feb 2012 07:41:37 GMT
Subject: Re: [PATCH 0/2] config includes, take 2
Message-ID: <7vobtc8l3i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120206062713.GA9699@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> ... But the point of
> duplicate suppression was that individual config files wouldn't have to
> know or care what was being included elsewhere.

I think you wanted to say "the point of inclusion mechanism" is that
individual configuration files would not have to know, and I think I
agree.

> So I'm actually thinking I should drop the duplicate suppression and
> just do some sort of sanity check on include-depth to break cycles
> (i.e., just die because it's a crazy thing to do, and we are really just
> trying to tell the user their config is broken rather than go into an
> infinite loop). As a bonus, it makes the code much simpler, too.

Yeah, I stand corrected. It was a bad suggestion.

Thanks.