From: Junio C Hamano Date: Fri, 03 Aug 2012 16:46:22 GMT Subject: Re: [PATCH] Fix 'No newline...' annotation in rewrite diffs. Message-ID: <7vobmrc49t.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120803160229.GA13094@sigill.intra.peff.net> Jeff King writes: > On Fri, Aug 03, 2012 at 07:49:47AM +0000, MichaƂ Kiedrowicz wrote: > >> Jeff King peff.net> writes: >> >> > - for i in $(seq 1 $GIT_PERF_REPEAT_COUNT); do >> > + for i in $("$PERL_PATH" -le "print for 1..$GIT_PERF_REPEAT_COUNT"); do >> >> Maybe you could introduce "test_seq" instead. > > I don't have a strong preference, as there are only two callsites. Do > you want to make a patch? If you run "for . in . . ." in t/, we see quite a many hits, so "only two callsites" might be undercounting the candidates.