From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Feb 2013 19:28:26 GMT
Subject: Re: [PATCH 3/4] Makefile: factor common configuration in git-default-config.mak
Message-ID: <7vobfv7wkl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1360174292-14793-4-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> Similarly to the extraction of perl-related code in perl.mak, we extract
> general default configuration from the Makefile to make it available from
> directories other than the toplevel.
>
> This is required to make perl.mak usable because it requires $(pathsep)
> to be set.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---

I really think this is going in a wrong direction.  Whatever you
happen to have chosen in this patch will be available to others,
while whatever are left out will not be.  When adding new things,
people need to ask if it needs to be sharable or not, and the right
answer to that question will even change over time.