From: Junio C Hamano Date: Sat, 09 Feb 2013 00:22:15 GMT Subject: Re: segfault for git log --graph --no-walk --grep a Message-ID: <7vobfuxrns.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vsj56xsg5.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Thomas Haller writes: > >> it happens in file revision.c:2306 because "commit->buffer" is zero: >> >> retval = grep_buffer(&opt->grep_filter, >> commit->buffer, strlen(commit->buffer)); > > I think this has been fixed at be5c9fb9049e (logmsg_reencode: lazily > load missing commit buffers, 2013-01-26); I haven't merged it to any > of the maintenance releases, but the tip of 'master' should have it > already. Ah, no, this shares the same roots as the breakage the said commit fixed, and the solution should use the same idea, but not fixed.