From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 25 Apr 2013 23:44:39 GMT
Subject: Re: [PATCH 0/2] "git add -A/--no-all" finishing touches
Message-ID: <7vobd2yy3c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vvc7ayy84.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Junio C Hamano wrote:
>>
>>> At the point of calling warn_pathless_add(), it seems that we are
>>> triggering this for paths that are not necessarily modified when run
>>> with "add -n -u".
>>
>> Do you mean files that were touched but have no content change, or
>> something more subtle?
>
> I had the change (which by the way needs a fix for the "found a
> directory" codepath) on top of master, uncommitted, and no other
> change (I also have some cruft that is not ignored).
>
>     cd Documentation && ../git add -n -u
>
> reported GIT-VERSION-GEN which was not touched.  It does not
> reproduce, though...

Ahh, I haven't run anything under the debugger yet, but I think I
know what is going on.

Don't we limit our "update-index --refresh" equivalent to the
original pathspec, even though your "-u/-A sans pathspec" warning
detection relies on grabbing the changes from the entire tree?