From: Junio C Hamano <junkio@cox.net>
Date: Thu, 18 May 2006 07:24:14 GMT
Subject: Re: [PATCH] Provide a way to flush git-diff-tree's output
Message-ID: <7vmzdf6bj5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <17516.6955.282732.460675@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> The --stdin flag to git-diff-tree is suitable for this, but the main
> difficulty is that the output of git-diff-tree gets buffered and
> doesn't get sent until the buffer is full.
>
> This provides a way to get git-diff-tree to flush its output buffers.
> If a blank line is supplied on git-diff-tree's standard input, it will
> flush its output buffers and then accept further input.

Sounds low impact and sane.

I suspect the usual caveat on bidirectional pipe deadlock
applies to the caller.  Does gitk do that?  The current code
seems to feed a pre-generated list with "open | cmd <<"
construct to the command, so perhaps you are planning to change
that?