From: Junio C Hamano Date: Thu, 29 Jun 2006 18:39:29 GMT Subject: Re: [PATCH] move get_merge_bases() to core lib; use it in merge-recursive Message-ID: <7vmzbvrela.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > My point being: it makes no sense to split off get_merge_bases() if nobody > uses it except for git-merge-base. I do not think that is a good reasoning. If something is reusable (or you made it reusable) and you are planning to reuse it later, splitting it out without changing anything else to make sure the split is correct is a seemingly small but a very important step.