From: Junio C Hamano <junkio@cox.net>
Date: Sat, 17 Feb 2007 18:25:00 GMT
Subject: Re: [PATCH] name-rev: introduce the --ref-filter=<regex> option
Message-ID: <7vmz3ctzer.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070217145921.GA16747@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sat, Feb 17, 2007 at 03:02:36PM +0100, Johannes Schindelin wrote:
>
>> > Instead of (or, in addition to) --tags, to use only tags for naming,
>> > you can now use --ref-filter=<regex> to specify which refs are
>> > used for naming.
>> > 
>> > Example:
>> > 
>> > 	$ git name-rev --ref-filter='/v1' 33db5f4d
>> > 	33db5f4d tags/v1.0rc1^0~1593
>> 
>> Likes, dislikes?
>
> It's a neat idea, but I wonder if you could make it even more flexible
> by simply accepting a list of possible refs, and then you could filter
> using grep, or your own more complex selection algorithm.
> Unfortunately, --stdin is already taken, but something like:
>
> git show-ref | grep tags/v1.4 | git name-rev --stdin-refs 33db5f4d

FWIW, I like that.