From: Junio C Hamano <junkio@cox.net>
Date: Mon, 14 May 2007 21:28:29 GMT
Subject: Re: [PATCH] cvsserver: Don't send mixed messages to clients
Message-ID: <7vmz07m6wy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070514131528.GC5272@planck.djpig.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

> After looking through all the uses of
> 	die "something"
> and
> 	print "E something";
> 	exit;
> and
> 	print "error 1 something";
> 	exit;
>
> in the current code I fail to see a real pattern there, is there any?
> If yes, we should maybe document it in a comment somewhere...
>
> For the record, cvs (server side) does the following in this particular situation:
> 	buf_output0 (buf_to_net, "I HATE YOU\n");
>         buf_flush (buf_to_net, true);
>
>         /* Don't worry about server_cleanup, server_active isn't set
>            yet.  */
>         exit (EXIT_FAILURE);

Ok, I stand corrected.  If there is a pattern to emulate, that
should be found in the real cvs server.