From: Junio C Hamano Date: Thu, 28 Jun 2007 04:30:25 GMT Subject: Re: [PATCH] Avoid perl in t1300-repo-config Message-ID: <7vmyykog4e.fsf@assigned-by-dhcp.pobox.com> In-Reply-To: <81b0412b0706270545w65ca2556yaafaac6ff31b5961@mail.gmail.com> "Alex Riesen" writes: > It fixes the test on system where ActiveState Perl is used. > It is also shorter. > ... > -git config --null --list | perl -0ne 'chop;($key,$value)=split(/\n/,$_,2);print "Key: $key\n";print "Value: $value\n" if defined($value)' > result > +git config --null --list | xargs -n1 -0 echo 'Key:' > result This now makes us rely on "xargs -0", which is probably much less portable than Perl isn't it? Because the point of the test is that it can show things in NUL terminated format, I'd rather keep it use a bit more portable stuff. Also I am not sure if the two tests are really testing the same thing. Maybe postprocess "git config -z" output with "tr '[\000]' 'Q'" or something so that the comparison of the result does not have to worry about NULs? I dunno. By the way, is it possible for gmail users to avoid attachments when sending patches in?