From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 25 Sep 2007 23:25:30 GMT
Subject: Re: [PATCH] Add ability to specify SMTP server port when using git-send-email.
Message-ID: <7vmyva2uqd.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vzlza2vcl.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> On Tue, 25 Sep 2007, Glenn Rempe wrote:
>>
>>> +if (($smtp_server =~ /:\d+/) && (defined $smtp_server_port)) {
>>
>> Not that I want to be a PITA, but this breaks down with IPv6, right?
>
> Right.  Do we care about symbolic "server.addre.ss:smtp"
> notation as well, I wonder?

Well, does it break?

BTW, I do not think we care about ":smtp"; it was a
tongue-in-cheek comment.