From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Nov 2007 01:10:45 GMT
Subject: Re: [RFC] use typechange as rename source
Message-ID: <7vmyswsfl6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071129141452.GA32670@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> OK. What next? Did the patch I sent make sense? Do you want a cleaned up
> version with a commit message and signoff, or does it need work?

It just hit me that breaking (as in diffcore-break) a filepair that is a
typechange may yield the same result, and if it works, that would be
conceptually cleaner.  After all, a typechange is the ultimate form of
total rewriting (the similarity between the preimage and the postimage
is very low -- even their types are different, let alone contents).

Compared to that, the rename_used++ in that codepath you touched feels
more magic to me.