From: Junio C Hamano Date: Sun, 06 Jan 2008 02:26:26 GMT Subject: Re: [PATCH] Test "git log --diff-filter" Message-ID: <7vmyrj7kq5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200801060033.03672.jnareb@gmail.com> Jakub Narebski writes: > My test checks all --diff-filter filters relevant to git-diff-tree, > i.e. ADMRCBT, and not only AMD. Ah, I see. Thanks --- that could have been stated in the log message. Maybe we would want to add them to existing test script, instead of adding a whole new one? > P.S. By the way, it is IMHO a bit strange that --pretty=oneline uses > newline as a terminator (it means that there is a newline at the end of > "git log --pretty=oneline), while --pretty="format:%s" uses newline as > a separator... Yeah, I tend to agree, although I learned to live with it long time ago.