From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 Feb 2008 18:37:29 GMT
Subject: Re: [PATCH] send-email: squelch warning due to comparing undefined $_ to ""
Message-ID: <7vmypv5v9y.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1203486907-12304-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> The check to see if initial_reply_to is defined was also comparing $_ to
> "" for a reason I cannot ascertain (looking at the commit which made the
> change didn't provide enlightenment), but if $_ is undefined, perl
> generates a warning.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> Junio, the commit which introduced the change was yours, but I don't
> see why you were comparing $_ to "". 

I think it was meant to check for $initial_reply_to being empty
(i.e. not compare $_ but the variable), but even if that is the
case I do not think the check would make a difference.

So the patch looks good.  Thanks.