From: Junio C Hamano Date: Wed, 12 Mar 2008 06:15:58 GMT Subject: Re: [PATCH v5 2/5] git-submodule summary: show commit summary Message-ID: <7vmyp479i9.fsf@gitster.siamese.dyndns.org> In-Reply-To: <46dff0320803112128j23337873jf1fb12f5716151d8@mail.gmail.com> "Ping Yin" writes: > On Wed, Mar 12, 2008 at 12:12 PM, Junio C Hamano wrote: >> --- a/git-submodule.sh >> +++ b/git-submodule.sh >> @@ -400,7 +400,7 @@ cmd_summary() { >> >> 160000) >> sha1_dst=$(GIT_DIR="$name/.git" git rev-parse HEAD) >> ;; >> - 100644) >> + 100644 | 100755 | 120000) >> > Are 644 and 755 file permission bit? If it is, how about the other > cases (655, 744 and so on)? They never appear, as git tracks only one executable bit, so mode bits for regular file blobs are canonicalized to either 100755 or 100644. Don't you ever see 000000 mode bits here? There is no case arm for that in the code.