From: Junio C Hamano Date: Sat, 07 Jun 2008 18:08:00 GMT Subject: Re: [TOY PATCH] git wrapper: show similar command names for an unknown command Message-ID: <7vmylxnmnz.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080607175103.GA5822@steel.home> Alex Riesen writes: > Johannes Schindelin, Sat, Jun 07, 2008 17:04:14 +0200: >> - for (i = 0; i < main_cmds.cnt; i++) { >> + for (i = 0; i < main_cmds.cnt && i < 5; i++) { > > I accidentally considered "i" just the index in the global command > table. Of course it is better :) That confusion however shows how hacky the approach to clobber the main_cmds global table by stuffing other things in it and sorting, without saying "who cares, we will exit after we are done with this processing anyway". If this patch were for inclusion, such a comment should be there immediately before it starts to muck with the command table.