From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 20 Sep 2008 22:29:15 GMT
Subject: Re: [PATCH v2 4/4] diff.c: convert builtin funcname patterns to non-GNU extended regex syntax
Message-ID: <7vmyi21mf8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <loom.20080920T200157-713@post.gmane.org>

Brandon Casey <drafnel@gmail.com> writes:

> Junio C Hamano <gitster <at> pobox.com> writes:
>
>> Here is [1/2] to be applied on top of 45d9414 (diff.*.xfuncname which uses
>> "extended" regex's for hunk header selection, 2008-09-18).
>> 
>> Testing appreciated.
>
>> +	{ "bibtex", "(@[a-zA-Z]{1,}[ \t]*\{{0,1}[ \t]*[^ \t\"@',\\#}{~%]*).*$",
>> +	  REG_EXTENDED },
>> +	{ "tex",
>> +	  "^(\\\\((sub)*section|chapter|part)\\*{0,1}\{.*)$",
>
> I think you need double backslash '\\' before '{' in the two places in these
> patterns where you only have a single backslash.

Thanks.  Any other nits?