From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Oct 2008 05:30:48 GMT
Subject: Re: [PATCH v3 7/8] wt-status: load diff ui config
Message-ID: <7vmygqiozb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081026044935.GG21047@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> But it makes me a little nervous. On one hand, I think it is definitely
> the right thing for "status -v" to respect user options. But we do
> several _other_ diffs in addition, and those are more "plumbing" diffs.
> I think they should probably at least have diff_basic_config (e.g., for
> rename limits). But we are applying the diff_ui_config options to all
> diffs. Looking over the available options, I _think_ there are no nasty
> surprises. But you never know.

Up to 6/8 are indisputably good changes.  The next one means well, and
this one is a requisite step for it, but I agree that this feels somewhat
risky.