From: Junio C Hamano Date: Sat, 27 Dec 2008 00:18:21 GMT Subject: Re: [PATCH] describe: Avoid unnecessary warning when using --all Message-ID: <7vmyeijws2.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20081226220201.GA20516@spearce.org> "Shawn O. Pearce" writes: > In 212945d4 ("Teach git-describe to verify annotated tag names > before output") git-describe learned how to output a warning if > an annotated tag object was matched but its internal name doesn't > match the local ref name. > > However, "git describe --all" causes the local ref name to be > prefixed with "tags/", so we need to skip over this prefix before > comparing the local ref name with the name recorded inside of the > tag object. > > Patch-by: René Scharfe > Signed-off-by: Shawn O. Pearce > --- > IMHO, suitable for maint... Yeah, do you prefer to be known as "sop" over "spearce" these days, by the way? It does not make a difference to me but I just noticed that Author and S-o-b won't be matching, so I am just being curious.