From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 20 Oct 2009 16:30:38 GMT
Subject: Re: [PATCH v2] new --dirty option for git describe
Message-ID: <7vmy3mownl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <dffdbd190910200727r30e161ffka0b3cf764be26cd8@mail.gmail.com>

Jean Privat <jean@pryen.org> writes:

> +test_expect_success 'describe --dirty HEAD' '
> +	git describe --dirty HEAD
> +	test $? != 0
> +'

We tend to write this as

	test_expect_success '...' '
        	test_must_fail git describe --dirty HEAD
	'

The difference is when the tested command segfaults or dies in an
uncontrolled fashion; test_must_fail diagnoses it as a failure,
while "test $? != 0" at the end will say "ok, the command correctly
failed".