From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 10 Jan 2010 06:31:43 GMT
Subject: Re: [PATCH] ls-files: fix overeager pathspec optimization
Message-ID: <7vmy0mfp2o.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.1001091004380.7821@localhost.localdomain>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Sat, 9 Jan 2010, Junio C Hamano wrote:
>> 
>> Having sent these patches, I am wondering if the simplest fix might be this
>> one-liner.
>> 
>> diff --git a/dir.c b/dir.c
>> index d0999ba..7fba335 100644
>> --- a/dir.c
>> +++ b/dir.c
>> @@ -788,3 +788,3 @@ int read_directory(struct dir_struct *dir, const char *path, int len, const char
>>  	simplify = create_simplify(pathspec);
>> -	read_directory_recursive(dir, path, len, 0, simplify);
>> +	read_directory_recursive(dir, "", 0, 0, simplify);
>>  	free_simplify(simplify);
>
> That one-liner doesn't work at all for me.
> ...
> IOW, it now ignores _everything_, because the dir and the path don't 
> match.

Hmph, you are right.  The real series is not equivalent to the one-liner
at all.