From: Junio C Hamano Date: Thu, 10 Jun 2010 15:54:54 GMT Subject: Re: [PATCH] read_cache: cast types from stat to ce_cache Message-ID: <7vmxv2nar5.fsf@alter.siamese.dyndns.org> In-Reply-To: Michael J Gruber writes: > - ce->ce_dev = st->st_dev; > - ce->ce_ino = st->st_ino; > - ce->ce_uid = st->st_uid; > - ce->ce_gid = st->st_gid; > - ce->ce_size = st->st_size; > + ce->ce_dev = (unsigned int)st->st_dev; > + ce->ce_ino = (unsigned int)st->st_ino; > + ce->ce_uid = (unsigned int)st->st_uid; > + ce->ce_gid = (unsigned int)st->st_gid; > + ce->ce_size = (unsigned int)st->st_size; I haven't had my morning coffee yet, but wouldn't the conversion be automatic by assignment anyway?