From: Junio C Hamano Date: Mon, 02 Aug 2010 17:22:42 GMT Subject: Re: [PATCH 1/5] t1011 (sparse checkout): style nitpicks Message-ID: <7vmxt5lyjh.fsf@alter.siamese.dyndns.org> In-Reply-To: <1280556869-707-2-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > From: Jonathan Nieder > > Tweak the rest of the script to more closely follow the test > style guide. Guarding setup commands with test_expect_success > makes it easy to see the scope in which some particular data is > used; removal of whitespace after >redirection operators is just > for consistency. > > Signed-off-by: Jonathan Nieder > Signed-off-by: Nguyễn Thái Ngọc Duy What happened to the 'test -z "$(cmd)" discards exit status from cmd' part of Jonathan's patch?