From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 03 Oct 2010 23:32:28 GMT
Subject: Re: [PATCHv6 07/16] t3600 (rm): add lots of missing &&
Message-ID: <7vmxquettf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101003205615.GB22743@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Maybe you would prefer something like this on top?  My only concern is
> to make sure the test is robust (even if people add new tests before
> these without paying much attention) and easy to read.
>
> I suppose I am nitpicking excessively because I do not like to see
> regressions, even in out-of-the-way code like this.

I do not think you are nitpicking at all; it is a key to maintainability
to make sure that the code is unlikely to be broken by future changes that
are not perfectly diligent.

Thanks.