From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Apr 2011 22:16:12 GMT
Subject: Re: Git exhausts memory.
Message-ID: <7vmxk4l4yb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.1104051655310.28032@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> writes:

>> > This is only implemented inside of fast-import. pack-objects does not
>> > honor this variable.
>> 
>> Do you mean perhaps we should?
>
> Yes.
>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>

I actually was somewhat unhappy to use uintmax_t type in the public header
for some reason I cannot quite explain (perhaps religious), and was hoping
somebody with more sanity than myself would stop me or show me a better
way.

>> diff --git a/cache.h b/cache.h
>> index 2674f4c..316d85f 100644
>> --- a/cache.h
>> +++ b/cache.h
>> @@ -573,6 +573,7 @@ extern int core_compression_seen;
>>  extern size_t packed_git_window_size;
>>  extern size_t packed_git_limit;
>>  extern size_t delta_base_cache_limit;
>> +extern uintmax_t big_file_threshold;
>>  extern int read_replace_refs;
>>  extern int fsync_object_files;
>>  extern int core_preload_index;