From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Apr 2011 16:58:49 GMT
Subject: Re: [PATCHv2 00/11] gitweb: Change timezone in dates using JavaScript
Message-ID: <7vmxjm5gae.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201104190836.16221.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Perhaps something like that would be a good change, what do you think?

Should be a lot saner thing to do.

Do we even need to know about JSMIN, GITWEB_JS, etc., in our main
Makefile?  Shouldn't we be delegating both the build and the install
targets to "$(MAKE) -C gitweb $@"?

> diff --git i/Makefile w/Makefile
> index cbc3fce..8960cee 100644
> --- i/Makefile
> +++ w/Makefile
> @@ -1773,7 +1773,7 @@ gitweb/static/gitweb.min.css: gitweb/static/gitweb.css
>  endif # CSSMIN
>  
>  
> -git-instaweb: git-instaweb.sh gitweb/gitweb.cgi gitweb/static/gitweb.css gitweb/static/gitweb.js
> +git-instaweb: git-instaweb.sh gitweb
>  	$(QUIET_GEN)$(RM) $@ $@+ && \
>  	sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
>  	    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \