From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 Aug 2011 18:13:15 GMT
Subject: Re: [PATCH v11 4/7] bisect: introduce support for --no-checkout option.
Message-ID: <7vmxfthuf8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1312199777-10144-5-git-send-email-jon.seymour@gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> diff --git a/bisect.c b/bisect.c
> index dd7e8ed..534da2c 100644
> --- a/bisect.c
> +++ b/bisect.c
> ...
> -	res = run_command_v_opt(argv_checkout, RUN_GIT_CMD);
> -	if (res)
> -		exit(res);
> +	if (no_checkout) {
> +	  argv_update_ref[3] = bisect_rev_hex;
> +	  if (run_command_v_opt(argv_update_ref, RUN_GIT_CMD))
> +	    die("update-ref --no-deref HEAD failed on %s", bisect_rev_hex);
> +	} else {
> +	  res = run_command_v_opt(argv_checkout, RUN_GIT_CMD);
> +	  if (res)
> +	    exit(res);
> +	}

Please. No indentations with just a few SPs.