From: Junio C Hamano Date: Fri, 06 Jan 2012 22:45:15 GMT Subject: Re: [PATCH] parse_object: try internal cache before reading object db Message-ID: <7vmxa0ih6s.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120106223324.GB13106@sigill.intra.peff.net> Jeff King writes: >> Even though it is a bit scary kind of loosening of sanity checks that I >> hesitate to take at this late in the cycle, I think it makes sense. Let's >> queue them on 'pu' and aim for the next cycle. > > Did you want to leave the parse_object optimization until next cycle, > too? It's not loosening checks, but it's such a core piece of code that > it makes me nervous somebody somewhere is abusing "struct object" in a > way that will break it. I was just updating the "What's cooking" report and my current thinking is that we should keep all three in "next" to give it a bit of exposure for now, and merge them to "master" early in the 1.7.10 cycle.