From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 Feb 2012 02:03:51 GMT
Subject: Re: [PATCH] Don't search files with an unset "grep" attribute
Message-ID: <7vmx92yos8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120201232027.GA32119@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> There are a few optimizations I didn't do that you could put on top:
>
>   1. When "-a" is given, we can avoid the attribute lookup altogether.

Correct.

>   2. When "-I" is given, we can actually check attributes _before_
>      loading the file or blob into memory. This can help with very large
>      binaries.

Nice.

> ... However, for large files, it might be nice to have a streaming grep
> interface anyway, and (3) could be part of that.

Even nicer ;-)